Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(MessagePayload): Specify typings for files and resolveFile #6608

Merged
merged 1 commit into from
Sep 8, 2021
Merged

types(MessagePayload): Specify typings for files and resolveFile #6608

merged 1 commit into from
Sep 8, 2021

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Sep 7, 2021 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
These two are currently typed as unknown but should now take HTTPAttachmentData.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite mentioned this pull request Sep 7, 2021
Merged
@iCrawl iCrawl added this to the Version 13.2 milestone Sep 8, 2021
@iCrawl iCrawl merged commit ea36955 into discordjs:main Sep 8, 2021
@Jiralite Jiralite deleted the payload-types branch September 8, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
semver:patch typings
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiralite @iCrawl @SpaceEEC