Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: workaround for test.ts type errors for typescript 4.5.0 #6931

Closed

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

This is currently a workaround to allow tests to compile on 4.5.0-beta, and be compatible with 4.4.4. This will most likely be reverted when the issue is resolved:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@suneettipirneni suneettipirneni changed the title types: fix test.ts type errors from typescript 4.5.0 types: workaround for test.ts type errors for typescript 4.5.0 Nov 1, 2021
@SpaceEEC SpaceEEC added the ci label Nov 1, 2021
@kyranet kyranet added the typings label Nov 2, 2021
@suneettipirneni
Copy link
Member Author

Closing this, issue should be resolved in the latest typescript@beta release

@suneettipirneni suneettipirneni deleted the fix/typescript-4.5 branch November 6, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants