fix(MessagePayload): prevent spread of undefined
#7029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
When passing
attachments: []
toMessageOptions
and nofiles
(to clear all attachments in a message edit), this code would result on the following logic to be executed:When spreading
undefined
, aTypeError
is thrown with the messageundefined is not iterable (cannot read property undefined)
on Node.js v16.3.0.Defaulting attachments to an empty array in that branch resolves the issue with the minimal impact possible.
Status and versioning classification: