Skip to content

fix(GuildAuditLogs): typings and consistency #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 15, 2022
Merged

fix(GuildAuditLogs): typings and consistency #7445

merged 8 commits into from
Feb 15, 2022

Conversation

ironm00n
Copy link
Contributor

@ironm00n ironm00n commented Feb 10, 2022 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Changes GuildAuditLogs typings to be accurate, adds AuditLogEvent to EnumResolvers, and updates tests.

Unfortunately, I had to remove one of the tests since typescript doesn't play well with numeric enums.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

imranbarbhuiya
imranbarbhuiya reviewed Feb 11, 2022
View reviewed changes
@ironm00n ironm00n marked this pull request as ready for review February 12, 2022 16:20
@ironm00n ironm00n closed this Feb 12, 2022
@ironm00n ironm00n reopened this Feb 12, 2022
@ironm00n ironm00n requested a review from kyranet February 12, 2022 23:10
@iCrawl iCrawl added this to the discord.js v14 milestone Feb 13, 2022
@iCrawl iCrawl merged commit c1b27f8 into discordjs:main Feb 15, 2022
almeidx pushed a commit to almeidx/discord.js that referenced this pull request Feb 15, 2022
@ironm00n @almeidx
fix(GuildAuditLogs): typings and consistency (discordjs#7445)
66c9550
@ironm00n ironm00n deleted the guild-audit-logs branch February 15, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhyrom xhyrom xhyrom left review comments

@imranbarbhuiya imranbarbhuiya imranbarbhuiya left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet Awaiting requested review from kyranet

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.
7 participants
@ironm00n @vladfrangu @iCrawl @kyranet @SpaceEEC @xhyrom @imranbarbhuiya