Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ThreadMemberManager): Support pagination fetching #9035

Merged
merged 24 commits into from
Feb 17, 2023
Merged

feat(ThreadMemberManager): Support pagination fetching #9035

merged 24 commits into from
Feb 17, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jan 9, 2023 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Jan 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 10:14PM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 10:14PM (UTC)

@suneettipirneni
Copy link
Member

Perhaps at some point we can make this an async iterator for fetching pages.

@Jiralite @almeidx
fix: send API properties correctly
25c3aec 
Co-authored-by: Almeida <almeidx@pm.me>
@Jiralite Jiralite added this to the discord.js v14.8 milestone Jan 9, 2023
@Jiralite Jiralite marked this pull request as ready for review January 9, 2023 22:40
@Jiralite
refactor: make member @private
7d0629f 
It will be confusing to have `guildMember` and `member`, specially since the former accounts for the latter.
@jaw0r3k jaw0r3k mentioned this pull request Jan 11, 2023
Merged
@kodiakhq kodiakhq bot merged commit 765d5a3 into discordjs:main Feb 17, 2023
@Jiralite Jiralite deleted the feat/thread-member-pagination branch February 17, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaw0r3k jaw0r3k jaw0r3k left review comments

@almeidx almeidx almeidx requested changes

@vladfrangu vladfrangu vladfrangu left review comments

@Syjalo Syjalo Syjalo requested changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl iCrawl approved these changes

Assignees
No one assigned
Labels
api support packages:discord.js REST semver:minor threads
Projects
discord.js
Archived in project
Milestone
discord.js 14.8
Development

Successfully merging this pull request may close these issues.
9 participants
@Jiralite @suneettipirneni @vladfrangu @iCrawl @kyranet @SpaceEEC @almeidx @Syjalo @jaw0r3k