Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ThreadManager): add members and conditionally include hasMore #9164

Merged
merged 3 commits into from
Mar 22, 2023
Merged

fix(ThreadManager): add members and conditionally include hasMore #9164

merged 3 commits into from
Mar 22, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Feb 23, 2023

Please describe the changes this PR makes and why it should be merged:

  • Fetching active threads in a guild does not yield the has_more property.1
  • has_more does not appear to be marked as missing or potentially null.234
  • members was not returned when fetching active threads in a guild.
  • The permission requirement to fetch active threads in the guild did not seem to be true. Discord's API documentation does not state this,1 but does for other thread-fetching methods.234

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Footnotes

  1. https://discord.com/developers/docs/resources/guild#list-active-guild-threads 2

  2. https://discord.com/developers/docs/resources/channel#list-public-archived-threads 2

  3. https://discord.com/developers/docs/resources/channel#list-private-archived-threads 2

  4. https://discord.com/developers/docs/resources/channel#list-joined-private-archived-threads 2

@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 7:24PM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 7:24PM (UTC)

@Jiralite Jiralite requested a review from ckohen February 23, 2023 14:05
@Jiralite Jiralite changed the title fix(ThreadManager): add members and conditionally include hasMore and fix(ThreadManager): add members and conditionally include hasMore and other fixes Feb 23, 2023
@Jiralite Jiralite added this to the discord.js 14.9 milestone Feb 23, 2023
@github-actions
Copy link

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants