perf(Role): Use iterable and exit early if found

[JMTK]

Please describe the changes this PR makes and why it should be merged:
This improves performance by not copying the role sorted collection into an array, which is how the spread syntax treats it. This should help with both memory and CPU since it creates a copy of the array. This does not fully address #3925 but would help mitigate some performance issues related to access the position property frequently.

Some profiling:

23000 iterations
Old: 66.575ms
New: 30.693ms

1 million iterations
Old: 761.495ms
New: 344.201ms

10 million iterations
Old: 7.964s
New: 3.588s

Status and versioning classification:
Patch

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)			May 1, 2023 8:08pm
discord-js-guide	⬜️ Ignored (Inspect)			May 1, 2023 8:08pm

[kyranet]

Otherwise LGTM.

[almeidx]

Couldn't this also be applied to GuildChannel#position? Or is it not relevant

discord.js/packages/discord.js/src/structures/GuildChannel.js

Lines 147 to 150 in a9f2bff

	get position() {
	const sorted = this.guild._sortedChannels(this);
	return [...sorted.values()].indexOf(sorted.get(this.id));
	}

[JMTK]

Couldn't this also be applied to GuildChannel#position? Or is it not relevant

Yeah definitely could. In my own use case I had a similar issue as the open issue on the repo, but it could definitely have the same type of problems if someone was looping through the channels