Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add getMemberBans() query options and getMemberBan() #9569

Merged
merged 1 commit into from
May 14, 2023
Merged

feat(api): add getMemberBans() query options and getMemberBan() #9569

merged 1 commit into from
May 14, 2023

Conversation

D4isDAVID
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
getMemberBan() isn't implemented at all and getMemberBans() currently doesn't support query options.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@D4isDAVID D4isDAVID requested a review from a team as a code owner May 14, 2023 02:11
@vercel
Copy link

vercel bot commented May 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) May 14, 2023 2:11am
discord-js-guide ⬜️ Ignored (Inspect) May 14, 2023 2:11am

suneettipirneni
suneettipirneni approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@suneettipirneni suneettipirneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Jiralite Jiralite added this to the core 0.7.0 milestone May 14, 2023
@kodiakhq kodiakhq bot merged commit 590f5bc into discordjs:main May 14, 2023
@D4isDAVID D4isDAVID deleted the core-api-guildbans branch May 14, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suneettipirneni suneettipirneni suneettipirneni approved these changes

@Jiralite Jiralite Jiralite approved these changes

@kyranet kyranet kyranet approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
api support packages:core semver:major
Projects
discord.js
Archived in project
Milestone
core 1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@D4isDAVID @kyranet @Jiralite @suneettipirneni