feat(slashcommands): add JSON objects along with builders #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also disagree with having this in the first place, we don't need a raw json example for everything, that'd be ass to maintain and just unneeded stuff cluttering the guide imo. What I would rather do is recommend builders and link to the api docs and perhaps mention discord-api-types for typescript users. In the case of the "advanced users", that should be enough for them. |
almostSouji
requested changes
Jun 12, 2022
|
Switched to enums |
almeidx
suggested changes
Jun 14, 2022
Co-authored-by: Almeida <almeidx@pm.me>
|
This will need to be revisited after the semantic and structural rewrite that's currently in progress |
|
It's probably better to remake this pr entirely (or rethink the idea as a whole) as the codebase has changed a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
#1122 Adding JSON objects as an alternative option to builders will allow advanced developers to
copy pasteunderstand code quickly and something that is more native to them.One question is whether the builders page should also have the JSON objects for direct comparison with builders or should they not have them as the page is specifically made for builders?