-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix build/release CI #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
ref: nodejs/node-gyp#2219
ref: nodejs/node-gyp#2869
This PR includes following changes:
apt update
beforeapt install
Current workflow does not succeed due to updates to python 3.12 in github runners.
Downgrading to python 3.8 is necessary in older node.js, because nodejs/node-gyp#2219 was fixed in gyp-next v0.7.0/node-gyp v0.8.0, which is not included in older node.js.
Also, macos-10.15 and ubuntu-18.04 runner job never starts, so I suggest removing them.
The
Failed to fetch 404 not found
error had occured because of this, and this PR also fixes that.Finally, I added macos-13 runner and node.js 20/21, because I think it is better to run test for these environment and provide prebuild.
However, if you feel these should be in another PR and discussed separately, I am willing to remove them.
Semantic versioning classification: