Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix build/release CI #148

Merged
merged 12 commits into from
Mar 9, 2024
Merged

ci: fix build/release CI #148

merged 12 commits into from
Mar 9, 2024

Conversation

femshima
Copy link
Contributor

@femshima femshima commented Nov 26, 2023

Please describe the changes this PR makes and why it should be merged:

ref: nodejs/node-gyp#2219
ref: nodejs/node-gyp#2869

This PR includes following changes:

Current workflow does not succeed due to updates to python 3.12 in github runners.

Fix python version to 3.8 in node <=17 and 19

Downgrading to python 3.8 is necessary in older node.js, because nodejs/node-gyp#2219 was fixed in gyp-next v0.7.0/node-gyp v0.8.0, which is not included in older node.js.

Remove macos-10.15 and ubuntu-18.04 runner

Also, macos-10.15 and ubuntu-18.04 runner job never starts, so I suggest removing them.

Add apt update before apt install

The Failed to fetch 404 not found error had occured because of this, and this PR also fixes that.

Add macos-13 runner
Add node.js 20 and 21

Finally, I added macos-13 runner and node.js 20/21, because I think it is better to run test for these environment and provide prebuild.
However, if you feel these should be in another PR and discussed separately, I am willing to remove them.

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@femshima femshima changed the title fix(ci): Fix build CI fix(ci): Fix build/release CI Nov 26, 2023
@femshima femshima marked this pull request as ready for review November 26, 2023 00:30
@vladfrangu vladfrangu changed the title fix(ci): Fix build/release CI ci: fix build/release CI Nov 26, 2023
@vladfrangu vladfrangu mentioned this pull request Feb 5, 2024
3 tasks
@iCrawl iCrawl merged commit c12c103 into discordjs:main Mar 9, 2024
100 checks passed
@femshima femshima deleted the fix-build-2 branch March 9, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants