Fix filtering of playing events by game or type #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-Worrall
suggested changes
Jan 12, 2017
| @@ -97,14 +97,14 @@ def matches?(event) | |||
| end, | |||
| matches_all(@attributes[:game], event.game) do |a, e| | |||
| a == if a.is_a? String | |||
| e.name | |||
| e | |||
| else | |||
| e | |||
| end | |||
There was a problem hiding this comment.
This call all just be written as a == e
| else | ||
| e | ||
| end | ||
| end, | ||
| matches_all(@attributes[:type], event.type) do |a, e| | ||
| a == if a.is_a? Integer | ||
| e.type | ||
| e | ||
| else | ||
| e | ||
| end |
sven-strothoff
force-pushed
the
fix-playing-event-handler
branch
from
64d76c8 to
516c612
Compare
|
Nice catch! |
|
Yeah, I had a strange feeling about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two small issues in the PlayingEventHandler that result in crashes if a filter for game or type is used.
During the initialisation of PlayingEvent the game object received from the server is flattened to its only attribute
name(presence.rb:75). In line 100event.game.nameis accessed, but at this pointevent.gameis only a string.For filtering by event type the
typeattribute is accessed twice (i.e.event.type.type) in lines 105 and 107.