Extension on Reaction events to return Member #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z64
reviewed
May 29, 2017
lib/discordrb/events/reactions.rb
Outdated
| @user = @bot.user(@user_id).on(@server) | ||
| else | ||
| @user = @bot.user(@user_id) | ||
| end |
There was a problem hiding this comment.
I believe this could be neatened to:
@user ||= if server
server.member(@user_id)
else
@bot.user(@user_id)
end
|
This is good to merge. I'm abstaining on the specs for now due to thinking about a better method of providing spec fixtures than the structure we have right now. Tested with eval code |
meew0
requested changes
Jun 23, 2017
lib/discordrb/events/reactions.rb
Outdated
| def user | ||
| # Cache the user so we don't do requests all the time | ||
| @user ||= @bot.user(@user_id) | ||
| @user ||= if server | ||
| @bot.user(@user_id).on(@server) |
There was a problem hiding this comment.
This can be simplified to @server.member(@user_id)
There was a problem hiding this comment.
I told him to do that but Nekka doesn't like me.
meew0
approved these changes
Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpecsWon't add yet