Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhooks that Work #356

Merged
merged 6 commits into from
Jun 13, 2017
Merged

Webhooks that Work #356

merged 6 commits into from
Jun 13, 2017

Conversation

Daniel-Worrall
Copy link
Contributor

@Daniel-Worrall Daniel-Worrall commented May 31, 2017 •
edited
Loading

  • specs

z64
z64 requested changes Jun 2, 2017
View reviewed changes
lib/discordrb/events/webhooks.rb

# Event handler for {WebhookUpdateEvent}
class WebhookUpdateEventHandler < EventHandler
def matches?(event)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an ID attribute match to this? I'm assuming there must be an ID in the event payload.. (it's not documented yet)

meew0
meew0 approved these changes Jun 13, 2017
View reviewed changes
Copy link
Collaborator

@meew0 meew0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done with the specs, thanks 👍

@meew0 meew0 merged commit 0974697 into discordrb:master Jun 13, 2017
@meew0 meew0 added this to the 3.3.0 milestone Jun 13, 2017
@meew0 meew0 added api-support Adds support for an existing Discord API feature enhancement labels Jun 13, 2017
@meew0 meew0 mentioned this pull request Jun 13, 2017
Closed
5 tasks
@Daniel-Worrall Daniel-Worrall deleted the webhooks branch June 19, 2017 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z64 z64 z64 requested changes

@meew0 meew0 meew0 approved these changes

Assignees
No one assigned
Labels
api-support Adds support for an existing Discord API feature enhancement
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel-Worrall @meew0 @z64