Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum Ruby version to 2.4 #583

Merged
merged 10 commits into from
Mar 9, 2019
Merged

Bump minimum Ruby version to 2.4 #583

merged 10 commits into from
Mar 9, 2019

Conversation

PanisSupraOmnia
Copy link
Contributor

This PR is for when we're ready to bump the minimum Ruby version to 2.4. This shouldn't be all that soon, but Ruby 2.3 reaches EOL next March, so it's not too far away.

z64
z64 reviewed Nov 8, 2018
View reviewed changes
Copy link
Collaborator

@z64 z64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to drop the CI job for 2.3 in this PR?

@z64 z64 added the on-hold label Nov 8, 2018
@z64
Copy link
Collaborator

z64 commented Mar 1, 2019

Hi @PanisSupraOmnia , it's now March, and EOL is the 31st.

I see you pushed a couple weeks ago; If this PR is up to date, let me know and we can move this forward. Thanks!

@z64 z64 self-requested a review March 1, 2019 16:20
@z64 z64 removed the on-hold label Mar 1, 2019
@PanisSupraOmnia
Copy link
Contributor Author

Rebased to run rubocop again, should be good to go. 👍

@z64
Copy link
Collaborator

z64 commented Mar 4, 2019

Does our Dependencies section need to be updated with this PR?

https://github.com/meew0/discordrb/blob/6f9dd82e57125092ba6c11f8c0e909193fa86b61/README.md#dependencies

@PanisSupraOmnia PanisSupraOmnia changed the title RuboCop PR 2, Electric Boogaloo (I'm so sorry) Bump minimum Ruby version to 2.4 Mar 4, 2019
@PanisSupraOmnia
Copy link
Contributor Author

Yes, I went ahead and updated it, and took the liberty of simplifying that part of the instructions for Windows given that the change in Devkit setup occurred in 2.4. Also, added 2.6 to the Travis test matrix/set the docs deploy to use it.

I realized that this PR's purpose is really to bump the minimum Ruby version, and that the RuboCop changes are just a part of that; I've renamed the PR accordingly.

Lastly, as can be seen by the commits, this PR is based on #587, so that PR should either be merged before this one, or just closed.

z64
z64 reviewed Mar 5, 2019
View reviewed changes
Copy link
Collaborator

@z64 z64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last detail, I promise :)

README.md Outdated Show resolved Hide resolved
@z64 @PanisSupraOmnia
Clarify the supported Ruby version
098527d 
Co-Authored-By: PanisSupraOmnia <adrien@bouldersmiths.com>
z64
z64 approved these changes Mar 5, 2019
View reviewed changes
Copy link
Collaborator

@z64 z64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@z64 z64 mentioned this pull request Mar 9, 2019
Closed
@z64 z64 merged commit 4b47a27 into discordrb:master Mar 9, 2019
@PanisSupraOmnia PanisSupraOmnia deleted the rubocop24 branch March 18, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z64 z64 z64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PanisSupraOmnia @z64