Skip to content

Commit

Permalink
DEV: Remove deprecated showFooter calls (#248)
Browse files Browse the repository at this point in the history
This is now handled in Discourse core via the `hide-application-footer` helper in the user-topics-list template
  • Loading branch information
davidtaylorhq authored Oct 2, 2023
1 parent fa05e02 commit 7995e87
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ export default class UserActivityReactions extends Controller {
@tracked beforeLikeId = null;
@tracked beforeReactionUserId = null;

constructor() {
super(...arguments);
this.set("application.showFooter", !this.canLoadMore);
}

#getLastIdFrom(array) {
return array.length ? array[array.length - 1].get("id") : null;
}
Expand Down Expand Up @@ -48,11 +43,6 @@ export default class UserActivityReactions extends Controller {

@action
loadMore() {
if (!this.canLoadMore || this.loading || !this.reactionsUrl) {
this.set("application.showFooter", !this.canLoadMore);
return;
}

this.loading = true;
const reactionUsers = this.model;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,5 @@ export default class UserActivityReactions extends DiscourseRoute {
reactionsUrl: "reactions",
username: this.modelFor("user").get("username"),
});
this.controllerFor("application").set("showFooter", loadedAll);
}
}

0 comments on commit 7995e87

Please sign in to comment.