-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test improvements #174
Merged
Merged
Test improvements #174
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f13ae5d
Test for recovery from backlog expiry
benlangfeld 0695d1b
There is no point asserting before the child process exits
benlangfeld 6efcbdd
Re-opening file descriptors is not material to this spec
benlangfeld 25a3c62
Makes forking spec simpler and less flaky
benlangfeld f887967
Reduces duplication in backend specs
benlangfeld dbf97ff
Tests storage reset recovery for all backends
benlangfeld 3c656ac
Tests backlog expiry actually working
benlangfeld 96f5284
Describes Postgres backend's expiry behaviour in tests
benlangfeld b6597fc
Asserts that both the global and channel backlogs get expired
benlangfeld 4d0e156
Only publish-trigger expiry for backends that require it
benlangfeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I much prefer reset methods, way cleaner