Delint #175
Merged
Delint #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
SamSaffron
reviewed
Nov 7, 2018
| </body> | ||
| </html> | ||
| HTML | ||
| html = <<~HTML |
There was a problem hiding this comment.
I am OK with dropping 2.2 support as it is EOL most of my gems have already done this, I know @jeremyevans tends to keeps support for older version, I wonder if he is ok with this.
There was a problem hiding this comment.
We dropped support for 2.2 in 35a0cb0.
There was a problem hiding this comment.
forgot about that, we missed a spot f07e499
benlangfeld
force-pushed
the
delint
branch
2 times, most recently
from
16263bb to
9d829c9
Compare
Explicitly pardons and builds a todo list of existing offences, with a view to correcting them over time.
|
This should be good to go :) |
|
cool looks good. Mixed on the change it made to chat with the HTML being indented, but I guess consistency should win here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.