Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spaces to opam root during setup-dkml CI #8

Open
jonahbeckford opened this issue Dec 30, 2022 · 0 comments
Open

Add spaces to opam root during setup-dkml CI #8

jonahbeckford opened this issue Dec 30, 2022 · 0 comments

Comments

@jonahbeckford
Copy link
Contributor

jonahbeckford commented Dec 30, 2022 •
edited
Loading

It is very common to have spaces in directory paths on Windows (ex. C:\Users\Jane Smith) and is not unusual on macOS either. Packages should not fail to build simply because a user has a space in their path.

The suggestion is to change the opam root to include a space. Examples:

  • /home/runner/work/has space
  • /home/has space
  • D:/a/has space
  • C:/GitLab-Runner/builds/has space

The suggestion is to make the default in a new version of CI (ex. dkml-workflows.1.3.0) use a space since it is a bug to not support spaces. However, if the field x-validation-path-with-spaces: false is present in all .opam files (use awk to check), then no space should be used.

Eventually this change of opam root may make it into the opam repository CI. But this issue needs to be implemented first.

Cross-links:
@jonahbeckford jonahbeckford mentioned this issue Dec 30, 2022
Closed
@jonahbeckford jonahbeckford changed the title Add spaces to opam root during CI Add spaces to opam root during setup-dkml CI Dec 30, 2022
@jonahbeckford jonahbeckford mentioned this issue Jan 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonahbeckford