Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spaces to opam root during CI #199

Open
jonahbeckford opened this issue Jan 2, 2023 · 1 comment · May be fixed by #200
Open

Add spaces to opam root during CI #199

jonahbeckford opened this issue Jan 2, 2023 · 1 comment · May be fixed by #200

Comments

@jonahbeckford
Copy link

It is very common to have spaces in directory paths on Windows (ex. C:\Users\Jane Smith) and is not unusual on macOS either. Packages should not fail to build simply because a user has a space in their path.

The suggestion is to change the opam root to include a space. Examples:

  • /home/runner/work/has space
  • /home/has space
  • D:/a/has space
  • C:/GitLab-Runner/builds/has space

The suggestion is to make the default in a new version of CI (ex. setup-ocaml.v2.1.0) use a space since it is a bug to not support spaces. However, if the field x-validation-path-with-spaces: false is present in all .opam files (can use awk to check), then no space should be used.

Cross-links:

@kit-ty-kate
Copy link
Contributor

It turns out OCaml itself doesn't support directories with spaces on non-Windows platforms: ocaml/ocaml#11590

I could try and see if there is a hack we could do to work around this but this sounds ugly and quite tricky. Asking @Octachron for a backport and a release seems to be a more reasonable path towards fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants