Add a check using a local switch with spaces in the directory name #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires ocaml/ocaml#11590 to be backported and 4.14.2 & 5.0.1 to be released before this can be merged in the current state. |
|
This also requires ocaml/ocaml#10727 that I need to split because the compiler installed doesn't works |
|
@Et7f3 - I think it should be fine, certainly for 5.0. ocaml/ocaml#11112 fixed the quoting of shebang lines. The fact 4.14 doesn't support it is less likely to be a problem - the compiler's build itself never calls shebang scripts, and virtually all tools will use the The only other change in ocaml/ocaml#10727 that's not related to the testsuite is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199
Fixes #137