pass interface and field name to Symbol ctor to be used as description #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disnet
reviewed
May 21, 2017
src/index.js
Outdated
| @@ -16,7 +16,7 @@ export syntax interface = ctx => { | |||
| let items = matchInterfaceItems(inner); | |||
| let fields = items.reduce((acc, item) => { | |||
| if (item.type === 'field' || item.type === 'static') { | |||
| return acc.concat(#`${item.name}: { value: Symbol(), | |||
| return acc.concat(#`${item.name}: { value: Symbol(${JSON.stringify(`${name}.${item.name}`)}), | |||
There was a problem hiding this comment.
Good call but Sweet's API is a bit low level right now and won't auto-cast a string value to a string literal token. You need to do:
Symbol(${fromStringLiteral(item.name, unwrap(name).value + '.' + unwrap(item.name).value)})(I'd normally use a template literal there but there's a bug I just discovered sweet-js/sweet-core#710 with function calls in template literals that I'm very surprised we hadn't run into before)
|
@disnet Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.