Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@deprecated on mixin member generates invalid code #1121

Closed
ghostbuster91 opened this issue Jul 26, 2023 · 1 comment · Fixed by #1123
Closed

@deprecated on mixin member generates invalid code #1121

ghostbuster91 opened this issue Jul 26, 2023 · 1 comment · Fixed by #1123

Comments

@ghostbuster91
Copy link
Contributor

Deprecating mixin member causes the code generation to output invalid code.
Tested with 0.17.12

Given:

@mixin
structure Extra {
    @deprecated
    @required
    name: String
}

structure Greeting with [Extra] {
    @required
    message: String
}

actual generated code:

trait Extra {
  def @deprecated(message = "N/A", since = "N/A") name: String
}

expected generated code:

trait Extra {
  @deprecated(message = "N/A", since = "N/A") 
  def name: String
}

Full code to reproduce the issue can be found here https://github.com/ghostbuster91/demos/tree/deprecated-issue-mixin

@kubukoz
Copy link
Member

kubukoz commented Jul 31, 2023

closed in #1123 and released in 0.17.13, for reasons unknown github (or github refined, idk) can't tell that the PR is part of that tag.

@kubukoz kubukoz closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants