Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of deprecated annotation in mixins #1123

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Fix rendering of deprecated annotation in mixins #1123

merged 2 commits into from
Jul 26, 2023

Conversation

ghostbuster91
Copy link
Contributor

This fixes #1121

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

kubukoz
kubukoz reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@kubukoz kubukoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this target 0.17? It'd be great to add in a patch rather than wait for 0.18.

@ghostbuster91 ghostbuster91 changed the base branch from series/0.18 to series/0.17 July 26, 2023 15:18
@ghostbuster91
Copy link
Contributor Author

can you make this target 0.17? It'd be great to add in a patch rather than wait for 0.18.

Good idea, changed.

@daddykotex
Copy link
Contributor

Thank you so much

@daddykotex
Copy link
Contributor

I'll happily port it to 0.18

@kubukoz kubukoz merged commit 39940fb into disneystreaming:series/0.17 Jul 26, 2023
12 checks passed
@kubukoz
Copy link
Member

kubukoz commented Jul 26, 2023

@daddykotex I'll open a backport, there's another PR to sync as well so I'll deal with them both

@daddykotex
Copy link
Contributor

ahh thanks :)

This was referenced Jul 26, 2023
Merged
Closed
lewisjkl pushed a commit that referenced this pull request Aug 1, 2023
@kubukoz @Baccata
@miguel-vila @ghostbuster91 @daddykotex
Merge 0.17 into 0.18... one more time. (#1124)
51af4e1 
* Add changelog entries for 0.17.7-12

* [skip ci] remove extra newline

* Backport service interpreter (address #1111) (#1118)

* Fix rendering of deprecated annotation in mixins (#1123)

Co-authored-by: ghostbuster91 <ghostbuster91@users.noreply.github.com>
Co-authored-by: David Francoeur <dfrancoeur04@gmail.com>

* Only transform AWS shapes named after standard shapes (#1127)

* Fixes AWS AwsStandardTypesTransformer bug

Only structure members can carry the `@default` trait.

* Fix sandbox

* add missing newline

---------

Co-authored-by: Olivier Mélois <baccata64@gmail.com>
Co-authored-by: Miguel Vilá <miguelvilag@gmail.com>
Co-authored-by: Kasper Kondzielski <kghost0@gmail.com>
Co-authored-by: ghostbuster91 <ghostbuster91@users.noreply.github.com>
Co-authored-by: David Francoeur <dfrancoeur04@gmail.com>
Co-authored-by: Olivier Mélois <olivier.melois@disneystreaming.com>
@kubukoz kubukoz mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daddykotex daddykotex daddykotex approved these changes

@kubukoz kubukoz kubukoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@deprecated on mixin member generates invalid code
4 participants
@ghostbuster91 @CLAassistant @daddykotex @kubukoz