Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport service interpreter (address #1111) #1118

Merged

Conversation

miguel-vila
Copy link
Contributor

@miguel-vila miguel-vila commented Jul 24, 2023

addresses #1111

@miguel-vila miguel-vila changed the base branch from series/0.18 to series/0.17 July 24, 2023 15:13
@miguel-vila miguel-vila marked this pull request as ready for review July 24, 2023 16:09
@kubukoz
Copy link
Member

kubukoz commented Jul 24, 2023

normally I'd ask for tests, but this being a backport of something already proven and tested on 0.18... I think it's fine

@Baccata
Copy link
Contributor

Baccata commented Jul 25, 2023

Let's pre-emptively add a change to the changelog file, describing the changes for the next version.

@kubukoz kubukoz merged commit a0186ae into disneystreaming:series/0.17 Jul 25, 2023
12 checks passed
@miguel-vila miguel-vila deleted the backport-service-interpreter branch July 26, 2023 15:36
lewisjkl pushed a commit that referenced this pull request Aug 1, 2023
* Add changelog entries for 0.17.7-12

* [skip ci] remove extra newline

* Backport service interpreter (address #1111) (#1118)

* Fix rendering of deprecated annotation in mixins (#1123)

Co-authored-by: ghostbuster91 <ghostbuster91@users.noreply.github.com>
Co-authored-by: David Francoeur <dfrancoeur04@gmail.com>

* Only transform AWS shapes named after standard shapes (#1127)

* Fixes AWS AwsStandardTypesTransformer bug

Only structure members can carry the `@default` trait.

* Fix sandbox

* add missing newline

---------

Co-authored-by: Olivier Mélois <baccata64@gmail.com>
Co-authored-by: Miguel Vilá <miguelvilag@gmail.com>
Co-authored-by: Kasper Kondzielski <kghost0@gmail.com>
Co-authored-by: ghostbuster91 <ghostbuster91@users.noreply.github.com>
Co-authored-by: David Francoeur <dfrancoeur04@gmail.com>
Co-authored-by: Olivier Mélois <olivier.melois@disneystreaming.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants