-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update smithy-model to 1.31.0, alloy to 0.2.2 #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good to me. As far as I can tell, the failures happen in the compliance tests module. I can help if you need
I'd appreciate that 😅 it might be a straightforward fix but I don't have the full context. Trying to make a bump of all the transitive versions of smithy-model so that there isn't any risk of incompatibilities in my build (it's happened before when modules from 1.27.x and 1.28.x were mixed) |
seems like 1.32.0 is available |
yeah, but we haven't updated the rest of the stack to it yet. We already have some alloy/smithy-translate deps, it's all on 1.31.0, but we're about to add a smithy4s dependency and we don't want to downgrade the others - hence trying to go to 1.31.0 here. Later on, presumably, we'd do the same for 1.32.0. Now that I think about it, should we tell Scala Steward to target |
modules/http4s/src/smithy4s/http4s/internals/SmithyHttp4sServerEndpoint.scala
Outdated
Show resolved
Hide resolved
Nope, unless it's limited to bumps of the |
all good from my side, @daddykotex are you happy to merge? |
No description provided.