Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smithy-model to 1.31.0, alloy to 0.2.2 #1022

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Jun 12, 2023

No description provided.

Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good to me. As far as I can tell, the failures happen in the compliance tests module. I can help if you need

@kubukoz
Copy link
Member Author

kubukoz commented Jun 12, 2023

I'd appreciate that 😅 it might be a straightforward fix but I don't have the full context. Trying to make a bump of all the transitive versions of smithy-model so that there isn't any risk of incompatibilities in my build (it's happened before when modules from 1.27.x and 1.28.x were mixed)

@daddykotex
Copy link
Contributor

seems like 1.32.0 is available

@kubukoz
Copy link
Member Author

kubukoz commented Jun 12, 2023

yeah, but we haven't updated the rest of the stack to it yet. We already have some alloy/smithy-translate deps, it's all on 1.31.0, but we're about to add a smithy4s dependency and we don't want to downgrade the others - hence trying to go to 1.31.0 here.

Later on, presumably, we'd do the same for 1.32.0. Now that I think about it, should we tell Scala Steward to target series/0.17 with its upgrades too?

@Baccata
Copy link
Contributor

Baccata commented Jun 13, 2023

should we tell Scala Steward to target series/0.17 with its upgrades too?

Nope, unless it's limited to bumps of the smithy-model library (and other libs from awslabs)

@kubukoz kubukoz marked this pull request as ready for review June 13, 2023 15:14
@kubukoz
Copy link
Member Author

kubukoz commented Jun 13, 2023

all good from my side, @daddykotex are you happy to merge?

@daddykotex daddykotex merged commit 9818649 into series/0.17 Jun 13, 2023
@Baccata Baccata deleted the update-smithy-model branch June 13, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants