Compliancetests fixes improvements #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve json assertion handling of empty string
kubukoz
reviewed
Dec 14, 2022
modules/compliance-tests/src/smithy4s/compliancetests/internals/package.scala
Outdated
Show resolved
Hide resolved
daddykotex
approved these changes
Dec 15, 2022
daddykotex
reviewed
Dec 15, 2022
modules/compliance-tests/src/smithy4s/compliancetests/internals/package.scala
Show resolved
Hide resolved
daddykotex
reviewed
Dec 15, 2022
modules/compliance-tests/src/smithy4s/compliancetests/internals/package.scala
Outdated
Show resolved
Hide resolved
changed uri to comparison to use renderString option instead of case class equality due to constant query params captured in the uri
Baccata
reviewed
Jan 5, 2023
modules/compliance-tests/src/smithy4s/compliancetests/internals/package.scala
Outdated
Show resolved
Hide resolved
Baccata
reviewed
Jan 5, 2023
modules/compliance-tests/src/smithy4s/compliancetests/internals/package.scala
Outdated
Show resolved
Hide resolved
Baccata
approved these changes
Jan 5, 2023
|
@daddykotex can you give this a review too please, in case I've missed something ? |
daddykotex
reviewed
Jan 5, 2023
modules/compliance-tests/src/smithy4s/compliancetests/internals/package.scala
Show resolved
Hide resolved
daddykotex
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few fixes for Compliance Tests module
There seems to be a problem with at least Scala3 Native tests failing for Compliance Tests module.
I've currently disabled the running of those tests by renaming the test/src folder to src-jvm-js