codegen cli should use a non-zero exit code when failing #713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when troubleshooting a problem with @yisraelU I found this issue.
Basically, because of a chicken-n-egg problem, we implement code generation for Smithy specifications, within this sbt build, as sourceGenerator. The implementation shells out to an external
java
process. The implementation useslineStream
which should throw if the process fails.Without this change, process returns 0, so no exception is thrown, even though the
processSpecs
method has thrown. This is tricky, becausesbt
does not see that an issue was raised, and just assume no files were generated. It then proceeds with the rest of the compilation but fails, because of missing class definition.With this change, the sourceGenerator responsible for codegeneration fails, and thus sbt does not proceed with compilation.
Before:
After: