[Core] Fix collision with known smithy4s construct names #848
Conversation
Add logic to prevent collisions shapes generated in other files, which Scala 3 seems to have trouble with when `"-source:3.0-migration"` is enabled
… compile to scala 3 too
type of implicit definition needs to be given explicitly
| import smithy4s.example.refined.Age.provider._ | ||
| import smithy4s.schema.Schema.int | ||
| import smithy4s.schema.Schema.struct | ||
|
|
||
| case class StructureWithRefinedMember(otherAge: Option[Age] = None) | ||
| case class StructureWithRefinedMember(otherAge: Option[smithy4s.example.refined.Age] = None) |
There was a problem hiding this comment.
What caused this to no longer be imported at the top? I see a few others as well so maybe a regression of some kind
There was a problem hiding this comment.
... guys, this is actually the bug that was fixed, f507ab2 reintroduces it ...
There was a problem hiding this comment.
The reason why the bug was not exhibited is that the compiler option added was incorrect. See :
There was a problem hiding this comment.
It is normal for the fully qualified name to be rendered here, because the Smithy namespace contains a shape of the same name, and Scala 3 is not happy about it.
Arguably this is a Scala 3 bug, but we can't not workaround on our side.
Now please one of you kindly revert the commit that re-introduced the bug.
There was a problem hiding this comment.
The reason why the bug was not exhibited is that the compiler option added was incorrect. See :
I dont know, I tried that first and got bad option: '-source:3.0-migration'
There was a problem hiding this comment.
I see this option only works with the Scala 3 compiler
reopens #847