Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: fallback unspecified members of deprecated trait to N/A #981

Conversation

i10416
Copy link
Contributor

@i10416 i10416 commented May 29, 2023

Scala compiler raises warning for deprecated annotation without message and/or since fields.

close #948

Perhaps, should we warn or inform users to encourage them to use deprecated trait with message and since fields via smithy language server?

Scala compiler raises warning for deprecated annotation without message
and/or since fields.

close disneystreaming#948
@daddykotex
Copy link
Contributor

Amazing, thanks for the PR

The CI is failing because part of the codebase (examples/) is code generated. This is because we like to have a visual on how code changes to the renderer affects the generated code. if you run sbt test_3_0_jvm, you'll get changes in the folder. You need to commit those.

I'll have a look but I think including a Smithy validator inside of alloy-core would give us the warning you're looking for.

Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR, that's amazing

@kubukoz
Copy link
Member

kubukoz commented May 29, 2023

Perhaps, should we warn or inform users to encourage them to use deprecated trait with message and since fields via smithy language server?

IMO that would live in the validators for the Smithy standard library, so not even a LS concern. I think we can have that discussion with the awslabs/smithy folks.

Copy link
Contributor

@Baccata Baccata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

@Baccata Baccata merged commit a5d30e0 into disneystreaming:series/0.18 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@deprecated w/o argument is deprecated
4 participants