-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global resource tests not running on Mill #113
Comments
lefou
pushed a commit
to com-lihaoyi/mill
that referenced
this issue
Oct 27, 2020
This PR removes a filter from the test discovery that ignores classes that have parameters in their constructor. I think this is problematic as it is perfectly valid for tests to have constructor parameters depending on the test framework, and so this should be a decision made by the testing framework rather than the build tool. Here's an example where I encountered this issue recently: disneystreaming/weaver-test#113. After running these tests again with the changes made in this PR the example tests shown in that issue now pass. I've attempted to verify that these changes are compatible with other test frameworks. With some fairly basic examples uTest and Scalatest both seem to continue to work as expected. I'd be happy to verify the changes against other test frameworks if you have any further suggestions. Commits: * Add VS Code to gitignore * Remove constraint for parameter count Pull request: #982
@RobinJDCox did this end up being a Mill issue or still a weaver issue? Looking at the wording of your PR in Mill it seems like this should resolve with next release of Mill? |
@keynmol this is a mill issue. We can close this. |
Yep, the Mill PR got merged which resolved my issue. Just waiting for the next release! 🙂 Thanks guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm having some trouble using global resource tests and I'm using Mill. This problem occurs with the latest version of Weaver (0.5.0).
If I define the following tests then neither of the two examples get run. I'm using ZIO, but have included both examples as I originally thought I'd done the Cats/ZIO interop wrong in the first example!
When running my tests, the test output prints the following which indicates that the
BasicGlobalInit
gets run but not the actual tests that are using it.It feels like this might be a problem specifically when running on Mill, but I've not confirmed that.
Thanks
Test Output
Example
The text was updated successfully, but these errors were encountered: