Dl poly dev #1726
Dl poly dev #1726
Conversation
There was a problem hiding this comment.
This is good - you have the guts of the thing in place. Seeing it written out like this and the way you have leveraged the FileAndFormat for this purpose makes me reconsider how we should be passing data around for these more complex file formats. Specifically, passing the long list of variables to the export function is functional, but not too pretty. It's beyond the scope of this PR, but creating intermediate classes to store the data in (e.g. DLPolyFieldFile) may be a better approach long term. This would make the DL_POLY stuff more like the implementation of Crystallographic Information File (CIF) handling, moving it beyond a simple I/O "option".
CMakeLists.txt
Outdated
There was a problem hiding this comment.
If you need to hack the CMakeLists.txt to build on your local machine then make sure not to commit those changes since this will break the CI in various places. I'm not sure exactly why you had to comment these bits out since they are disabled by default, however?
flake.nix
Outdated
There was a problem hiding this comment.
I appreciate that you added this so you could compile DL_POLY within nix, but again this is outside of the Dissolve scope and shouldn't be included in this PR.
src/io/export/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Alphabetical file order within suffix sections.
| #include "base/sysFunc.h" | ||
| #include "classes/configuration.h" | ||
| #include "data/atomicMasses.h" | ||
|
|
| formats_ = EnumOptions<DlPolyFieldExportFileFormat::DlPolyFieldExportFormat>( | ||
| "FieldExportFileFormat", {{DlPolyFieldExportFormat::DLPOLY, "dlpoly", "DL_POLY FIELD File"}}); | ||
| } | ||
|
|
| if (!parser.writeLineF("finish\n")) | ||
| return false; | ||
|
|
||
| int vdw = 0; |
There was a problem hiding this comment.
| int vdw = 0; | |
| auto vdw = 0; |
tests/modules/CMakeLists.txt
Outdated
No description provided.