Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Peak finding #1978

Merged
merged 19 commits into from
Nov 5, 2024
Merged

feat: Peak finding #1978

merged 19 commits into from
Nov 5, 2024

Conversation

RobBuchananCompPhys
Copy link
Contributor

@RobBuchananCompPhys RobBuchananCompPhys commented Sep 27, 2024

Part of #1979

This class allows us to do the following peak-related operations on 1D data:

  • Find peaks, with the option of specifying a vertical threshold or horizontal isolation to constrain the peaks
  • Find their prominences
  • Rank them by value from highest to lowest
  • Struct containers for peaks provides a way of describing each data peak in terms of their location and peak value
  • With the use of isolation, the peak finding can be robust to random noise

@RobBuchananCompPhys RobBuchananCompPhys changed the title fitting funcs - peak finding feat: Basic fitting functionality Sep 27, 2024
@RobBuchananCompPhys RobBuchananCompPhys linked an issue Sep 27, 2024 that may be closed by this pull request
@RobBuchananCompPhys RobBuchananCompPhys changed the title feat: Basic fitting functionality feat: Peak finding Sep 27, 2024
@RobBuchananCompPhys RobBuchananCompPhys marked this pull request as ready for review September 27, 2024 15:24
Copy link
Contributor

@rprospero rprospero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your numerical methods background is both more recent and more intensive than mine, so my suggestions might be out of line due to my missing crucial details. In that case, many of my comments could be corrected with just some explanatory comments.

src/math/peaks.cpp Outdated Show resolved Hide resolved
src/math/peaks.cpp Outdated Show resolved Hide resolved
src/math/peaks.h Outdated Show resolved Hide resolved
src/math/peaks.cpp Outdated Show resolved Hide resolved
src/math/peaks.h Outdated Show resolved Hide resolved
src/math/peaks.cpp Outdated Show resolved Hide resolved
@RobBuchananCompPhys
Copy link
Contributor Author

@rprospero FYI - I attach documentation from Mathworks detailing the prominence algorithm we're using here.

@RobBuchananCompPhys RobBuchananCompPhys merged commit cc3dfe0 into develop Nov 5, 2024
9 checks passed
@RobBuchananCompPhys RobBuchananCompPhys deleted the feat/fitting-algos branch November 5, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants