-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Peak finding #1978
feat: Peak finding #1978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your numerical methods background is both more recent and more intensive than mine, so my suggestions might be out of line due to my missing crucial details. In that case, many of my comments could be corrected with just some explanatory comments.
@rprospero FYI - I attach documentation from Mathworks detailing the prominence algorithm we're using here. |
Part of #1979
This class allows us to do the following peak-related operations on 1D data: