Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock server: show more info when a call fails #128

Merged
merged 1 commit into from
Mar 18, 2024
Merged

mock server: show more info when a call fails #128

merged 1 commit into from
Mar 18, 2024

Conversation

chriso
Copy link
Contributor

@chriso chriso commented Mar 18, 2024

This PR improves logging when a call from the mock server fails (#126).

Before:

2024-03-18 13:53:45 [WARN] call to function send_message failed (PERMANENT_ERROR)

After:

2024-03-18 13:53:45 [WARN] call to function send_message failed (PERMANENT_ERROR => NameError: name 'resopnse' is not defined)

@chriso chriso self-assigned this Mar 18, 2024
achille-roussel
achille-roussel approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@chriso chriso merged commit 126ed48 into main Mar 18, 2024
3 checks passed
@chriso chriso deleted the unpack-exit-result-error branch March 18, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achille-roussel achille-roussel achille-roussel approved these changes

@pelletier pelletier Awaiting requested review from pelletier

@Pryz Pryz Awaiting requested review from Pryz

Assignees

@chriso chriso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriso @achille-roussel