Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UX improvements #138

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Minor UX improvements #138

merged 2 commits into from
Mar 26, 2024

Conversation

chriso
Copy link
Contributor

@chriso chriso commented Mar 26, 2024

Two improvements I noticed:

  • I moved the batch helper from dispatch.fastapi.Dispatch to the dispatch.function.Registry base class, so that it can be used when you construct a remote endpoint registry (Remote endpoints #134)
  • when quitting the python -m dispatch.test server with SIGINT / Ctrl+C, previously it would print a stack trace from where the KeyboardInterrupt was raised. Now it prints a nice single-line exit message

Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@chriso chriso merged commit b3f8af3 into main Mar 26, 2024
3 checks passed
@chriso chriso deleted the minor-ux branch March 26, 2024 03:34
@chriso chriso self-assigned this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants