Check formatting as part of CI #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that both isort and black are run, and that both output a diff showing what formatting changes are required. If either command fails, fail the make command.
achille-roussel
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now check formatting as part of CI.
If either
isortorblackfind formatting issues they'll print a diff and fail with a non-zero exit code. Care has been taken to ensure that both tools run even if the other has an issue, so that we don't waste time fixing an issue only to find on the next push that the other tool found an issue too.Here's an example run showing both tools reporting issues: https://github.com/stealthrocket/dispatch-sdk-python/actions/runs/7794739825/job/21256564318.
This fixes #14.