Incorporate review comments

displague · Jul 9, 2020 · 5fc6050 · 5fc6050
1 parent 8a66270
commit 5fc6050
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/cmd/tink-cli/cmd/hardware/all.go b/cmd/tink-cli/cmd/hardware/all.go
@@ -12,7 +12,7 @@ import (
 	"github.com/tinkerbell/tink/protos/hardware"
 )
 
-// listCmd represents the all command
+// listCmd represents the list command
 var listCmd = &cobra.Command{
 	Use:   "list",
 	Short: "list all known hardware",
@@ -35,7 +35,7 @@ var listCmd = &cobra.Command{
 			}
 		}
 		if err != nil && err != io.EOF {
-			log.Println(err)
+			log.Fatal(err)
 		} else {
 			t.Render()
 		}

diff --git a/cmd/tink-cli/cmd/hardware/commands.go b/cmd/tink-cli/cmd/hardware/commands.go
@@ -46,7 +46,7 @@ func printOutput(data bool, hw *hardware.Hardware, input string) {
 	} else {
 		hwData, err := json.Marshal(hw)
 		if err != nil {
-			log.Println("Failed to marshal hardware data", err)
+			log.Fatal("Failed to marshal hardware data", err)
 		} else {
 			log.Println(string(hwData))
 		}

diff --git a/cmd/tink-cli/cmd/hardware/ip.go b/cmd/tink-cli/cmd/hardware/ip.go
@@ -44,7 +44,7 @@ var ipCmd = &cobra.Command{
 
 func addIPFlags() {
 	flags := ipCmd.Flags()
-	flags.BoolVarP(&data, "details", "d", false, "Provide the complete hardware details in json format")
+	flags.BoolVarP(&data, "details", "d", false, "provide the complete hardware details in json format")
 }
 
 func init() {

diff --git a/cmd/tink-cli/cmd/hardware/mac.go b/cmd/tink-cli/cmd/hardware/mac.go
@@ -42,7 +42,7 @@ var macCmd = &cobra.Command{
 
 func addMacFlags() {
 	flags := macCmd.Flags()
-	flags.BoolVarP(&data, "details", "d", false, "Provide the complete hardware details in json format")
+	flags.BoolVarP(&data, "details", "d", false, "provide the complete hardware details in json format")
 }
 
 func init() {