-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails with my .arcrc which only contains token #22
Comments
Phabricator has moved on from the clunky user+certificate-based authentication scheme into one that provides the API user with a single token that can be used directly. This change adds support for that and prefers it when available. Fixes disqus#22.
Do tests pass after including this commit? I see this failure:
In the following tests: test_connect (phabricator.tests.PhabricatorTest) ... ERROR |
Phabricator has moved on from the clunky user+certificate-based authentication scheme into one that provides the API user with a single token that can be used directly. This change adds support for that and prefers it when available. Fixes disqus#22.
Oops, apparently the tests used the installed version so I was misled into thinking they were passing. This new commit fixes that. |
Backport upstream pull request #23 [1] that adds support for new style token-based authentication. This PR fixes issue #22 [2]. Additionally modify the patch to add the token argument to the and of the argument list as per upstream pull request comment. This change fixes errors associated with not being able to find 'user' or 'cert' configuration keys (in ~/.arcrc) keys when using token based authentication. This was reproducible with deskutils/py-bugwarrior - Sort Makefile - Sort USE_PYTHON values - Canonicalize regression-test invocation [1] disqus/python-phabricator#23 [2] disqus/python-phabricator#22 Approved by: sbz (maintainer) Differential Revision: https://reviews.freebsd.org/D2983 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@392126 35697150-7ecd-e111-bb59-0022644237b5
Backport upstream pull request #23 [1] that adds support for new style token-based authentication. This PR fixes issue #22 [2]. Additionally modify the patch to add the token argument to the and of the argument list as per upstream pull request comment. This change fixes errors associated with not being able to find 'user' or 'cert' configuration keys (in ~/.arcrc) keys when using token based authentication. This was reproducible with deskutils/py-bugwarrior - Sort Makefile - Sort USE_PYTHON values - Canonicalize regression-test invocation [1] disqus/python-phabricator#23 [2] disqus/python-phabricator#22 Approved by: sbz (maintainer) Differential Revision: https://reviews.freebsd.org/D2983
Phabricator has moved on from the clunky user+certificate-based authentication scheme into one that provides the API user with a single token that can be used directly. This change adds support for that and prefers it when available. Fixes disqus#22.
My .arcrc was produced by running arc install-certificate and looks like this:
python-phabricator complains about not finding the user key and, after I added it by hand, it complains about the cert key not being found:
The text was updated successfully, but these errors were encountered: