Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing a tui dashboard for paddler as an alternative to using the dashboard web model. #31

Merged
merged 28 commits into from
Dec 5, 2024

Conversation

Propfend
Copy link
Collaborator

@Propfend Propfend commented Dec 4, 2024

No description provided.

Copy link
Member

@mcharytoniuk mcharytoniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks great. Thank you for the contribution. I have two issues to resolve though:

  1. table item sizes
  2. making sure all the ratatui_dashboard modules are behind a feature flag

src/cmd/mod.rs Outdated
@@ -1,5 +1,4 @@
pub mod agent;
pub mod balancer;

#[cfg(feature = "ratatui_dashboard")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far the PR looks great. Can you make sure that ratatui_dashboard is behind a feature flag and Paddler works and compiles without ratatui_dashboard feature flag enabled?

src/cmd/dashboard/app.rs Outdated Show resolved Hide resolved
@mcharytoniuk mcharytoniuk merged commit 8cce384 into distantmagic:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants