-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing a tui dashboard for paddler as an alternative to using the dashboard web model. #31
Conversation
…d coroutines with select!
This reverts commit a3ce20e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks great. Thank you for the contribution. I have two issues to resolve though:
- table item sizes
- making sure all the
ratatui_dashboard
modules are behind a feature flag
src/cmd/mod.rs
Outdated
@@ -1,5 +1,4 @@ | |||
pub mod agent; | |||
pub mod balancer; | |||
|
|||
#[cfg(feature = "ratatui_dashboard")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far the PR looks great. Can you make sure that ratatui_dashboard
is behind a feature flag and Paddler works and compiles without ratatui_dashboard
feature flag enabled?
…ven though we cant fetch agents).
No description provided.