feat: added yearQuarter field to NeedsAssessment.Survey
#202
+41
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtfairbank
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
praise: @swizzard prefect! I pushed a quick nitpick commit to clear up some CI/CD issues, but no big feedback or changes needed!
I noticed the PR was still in Draft mode and switched it to "ready for review". If you're ready, feel free to smash the merge button!
configured field to be auto-populated in CMS and API routes added tests for CMS route
…or change to the Survey.yearQuarter format
jtfairbank
force-pushed
the
feat/191/survey-combo-field
branch
from
a54a2ce to
9bcf504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added
yearQuarterfield toNeedsAssessment.Surveyper #191How can you test this?
Making this a draft until testing is more fleshed out