fix: restyle donation buttons, add omprakash #210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jimthedev is this one still in draft state or ready for review? Agree that visual test for these is fine for now! |
|
@jtfairbank I got ahead of myself so this is still a draft for now. I did leave some questions on #89 that will probably need to be looked over for me to proceed. I probably need to get connected in more to proceed. I expect being at some coworking sessions will help. |
|
Thanks for flagging that @jimthedev! Replied to your questions and hope to see you at some of the coworks this week. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: opened as a draft PR since I have some questions I need answered.
What changed?
#89
How will this change be visible?
Donation components will change. I did add some questions / comments to the project task
How can you test this change?
I will probably just visual test these. None of them have any props at the moment. I don't really know how they intend to be reused yet. We could add some props if that would be helpful but it seems a bit like we just want to know they can be reused. Happy to add these buttons other places in this PR.