review comments

distributed-system-analysis · May 10, 2023 · 03f7feb · 03f7feb
1 parent a97a29b
commit 03f7feb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/pbench/cli/server/shell.py b/lib/pbench/cli/server/shell.py
@@ -112,10 +112,10 @@ def run_gunicorn(server_config: PbenchServerConfig, logger: Logger) -> int:
         notifier.notify("STOPPING=1")
         notifier.notify("STATUS=OPENID broker not configured")
         return 1
-    except [
+    except (
         OpenIDClient.ServerConnectionError,
         OpenIDClient.ServerConnectionTimedOut,
-    ] as exc:
+    ) as exc:
         logger.warning("OpenID Connect client not reachable, {}", exc)
         notifier.notify("STOPPING=1")
         notifier.notify("STATUS=OPENID broker not responding")

diff --git a/lib/pbench/test/unit/server/auth/test_auth.py b/lib/pbench/test/unit/server/auth/test_auth.py
@@ -292,7 +292,7 @@ class TestOpenIDClient:
 
     @responses.activate
     def test_wait_for_oidc_server_fail(self, make_logger):
-        """Verfiy .wait_for_oidc_server() failure mode"""
+        """Verify .wait_for_oidc_server() failure mode"""
         # Start with an empty configuration, no openid section
         config = configparser.ConfigParser()
         with pytest.raises(OpenIDClient.NotConfigured):
@@ -329,7 +329,7 @@ def test_wait_for_oidc_server_fail(self, make_logger):
 
     @responses.activate
     def test_wait_for_oidc_server_succ(self, make_logger):
-        """Verfiy .wait_for_oidc_server() success mode"""
+        """Verify .wait_for_oidc_server() success mode"""
 
         config = configparser.ConfigParser()
         section = {"server_url": "https://example.com"}