Gracefully handle duplicate name with unique MD5 #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
added
Server
API
PBENCH-1112 In testing we're seeing duplicate tarball names with distinct MD5 values. We have reduced the importance of duplicate tarball names, relying on the dataset resource ID (MD5) for "uniqueness" internally. However the cache manager still maintains tarball files and MD5 companions on disk, and the upload API has to temporarily store the API payload somewhere. When the duplicate tarballs are uploaded concurrently, the `.open()` fails, leading to an internal server error. Instead, move temporarily upload files into an MD5-based subdirectory, and clean up that directory after upload completes.
I removed unused fixtures (particularly supporting the obsolete "controller" header). Also slightly rearranged some code in upload: I removed a new exception handler that's not really necessary and realized that some post-upload checks were unnecessarily inside the `with` block.
dbutenhof
added a commit
to dbutenhof/pbench
that referenced
this pull request
May 18, 2023
…analysis#3355) * Gracefully handle duplicate name with unique MD5 PBENCH-1112 In testing we're seeing duplicate tarball names with distinct MD5 values. We have reduced the importance of duplicate tarball names, relying on the dataset resource ID (MD5) for "uniqueness" internally. However the cache manager still maintains tarball files and MD5 companions on disk, and the upload API has to temporarily store the API payload somewhere. When the duplicate tarballs are uploaded concurrently, the `.open()` fails, leading to an internal server error. We want to minimize the chance of reporting internal server errors where possible. Instead, move temporarily upload files into an MD5-based subdirectory, and clean up that directory after upload completes.
dbutenhof
added a commit
that referenced
this pull request
May 22, 2023
* Gracefully handle duplicate name with unique MD5 PBENCH-1112 PBENCH-1150 In testing we're seeing duplicate tarball names with distinct MD5 values. We have reduced the importance of duplicate tarball names, relying on the dataset resource ID (MD5) for "uniqueness" internally. However the cache manager still maintains tarball files and MD5 companions on disk, and the upload API has to temporarily store the API payload somewhere. When the duplicate tarballs are uploaded concurrently, the `.open()` fails, leading to an internal server error. We want to minimize the chance of reporting internal server errors where possible. Instead, move temporarily upload files into an MD5-based subdirectory, and clean up that directory after upload completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1112
In testing we're seeing duplicate tarball names with distinct MD5 values. We have reduced the importance of duplicate tarball names, relying on the dataset resource ID (MD5) for "uniqueness" internally. However the cache manager still maintains tarball files and MD5 companions on disk, and the upload API has to temporarily store the API payload somewhere. When the duplicate tarballs are uploaded concurrently, the
.open()fails, leading to an internal server error.Instead, move temporary upload files into an MD5-based subdirectory, and clean up that directory after upload completes.
NOTE: I'm pushing this early as a draft for testing and exposure. I still need to write some unit tests this afternoon before it's formally ready for review.