Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prettier formatting check to the Dashboard lint check #3358

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Add Prettier formatting check to the Dashboard lint check #3358

merged 3 commits into from
Mar 23, 2023

Conversation

webbnh
Copy link
Member

@webbnh webbnh commented Mar 22, 2023 •
edited
Loading

We assume that code for the Dashboard is formatted via Prettier. This change adds a command to the Dashboard run_list Makefile target to check and enforce this. And, it makes additional changes to conform to Prettier's requirements.

PBENCH-1114

@webbnh webbnh added Code Infrastructure Dashboard Of and relating to the Dashboard GUI labels Mar 22, 2023
@webbnh webbnh added this to the v0.73 milestone Mar 22, 2023
@webbnh webbnh self-assigned this Mar 22, 2023
dbutenhof
dbutenhof previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🎊

@webbnh webbnh marked this pull request as ready for review March 22, 2023 23:09
@webbnh
Copy link
Member Author

webbnh commented Mar 22, 2023

OK, this PR is now ready for review. (I recommend suppressing whitespace differences in diff's output.)

npalaska
npalaska approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@npalaska npalaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added it as a CI check in one of my commit under #3250 😄 , but I was hesitating to add it on openid-connect branch because of the potential merge conflicts but its good you added it against the main branch so I won't have any merge conflict 🎉

@npalaska
Copy link
Member

npalaska commented Mar 23, 2023 •
edited
Loading

Also, should we add the check in our build.sh file like ( cd dashboard && npx eslint --max-warnings 0 "src/**" && npx prettier --check "src/**/*.js" > /dev/null)?

@webbnh
Copy link
Member Author

webbnh commented Mar 23, 2023

should we add the check in our build.sh file

It's in there! 😁

build.sh runs the Dashboard makefile, and this PR adds the check to the Makefile target.

@webbnh webbnh merged commit 91980b0 into distributed-system-analysis:main Mar 23, 2023
@webbnh webbnh deleted the add-prettier-check branch March 23, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@npalaska npalaska npalaska approved these changes

@MVarshini MVarshini Awaiting requested review from MVarshini

Assignees

@webbnh webbnh

Labels
Code Infrastructure Dashboard Of and relating to the Dashboard GUI
Projects
None yet
Milestone
v0.73
Development

Successfully merging this pull request may close these issues.
3 participants
@webbnh @npalaska @dbutenhof