Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contrib scripts for Perfconf demo #3363

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

webbnh
Copy link
Member

@webbnh webbnh commented Mar 28, 2023

In the pbench script:

  • Change the container tag from latest (which is the latest release) to main (which is the latest "published" image).
  • Use --security-opt=label=disable to avoid problems with relabeling the ~/.ssh directory contents.

In the pbench_demo script:

  • Move the invocation of pbench-generate-token to the beginning of the commands, to help "fail early" in the event of configuration problems.
  • Change the run-time from 20s to 5s.
  • Add an explanatory comment to a bit of subtlety.

- Remove the SELinux labeling of the ~/.ssh directory, since it disrupts the
  use of it from _outside_ the container.
- Switch the default container tag from `latest` to `main`, because we haven't
  done a release build of the Agent since we updated the containerization.
- Move the generate-token invocation "first" in the demo script, to help fail
  early.

PBENCH-1115
@webbnh webbnh added Agent Containerization Of and relating to the process of setting up and maintaining container images labels Mar 28, 2023
@webbnh webbnh added this to the v0.72 milestone Mar 28, 2023
@webbnh webbnh self-assigned this Mar 28, 2023
@webbnh webbnh merged commit 8518937 into distributed-system-analysis:main Mar 28, 2023
@webbnh webbnh deleted the perfconf-demo branch March 29, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Containerization Of and relating to the process of setting up and maintaining container images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant