Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return "raw" API parameters in pagination #3412

Merged
merged 3 commits into from
May 3, 2023
Merged

Return "raw" API parameters in pagination #3412

merged 3 commits into from
May 3, 2023

Commits on May 3, 2023

  1. Return "raw" API parameters in pagination 

    PBENCH-1133

The `GET /datasets` response is optimized for sequential pagination, providing
a convenient "next_url" string that can be used directly. However if a client
wants to support "random access" pagination, this requires that the client
parses the URL string in order to modify the `offset` parameter.

This attempts to make that a bit easier by supplementing the current response
payload with a `parameters` field containing the query parameters JSON object,
making it easy to update the `offset` parameter.

(Making the unit tests work against the normalized parameter list proved a bit
challenging and I ended up saving the original "raw" client parameters in the
API `context` so they can be used directly.)
    @dbutenhof
    dbutenhof committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2e6516e View commit details
    Browse the repository at this point in the history

  2. Review comments

    @dbutenhof
    dbutenhof committed May 3, 2023
    Configuration menu
    Copy the full SHA
    71c5adc View commit details
    Browse the repository at this point in the history

  3. Restore black's treasured trailing comma ... :-(

    @dbutenhof
    dbutenhof committed May 3, 2023
    Configuration menu
    Copy the full SHA
    fd46d98 View commit details
    Browse the repository at this point in the history