-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard API Key Management #3423
Dashboard API Key Management #3423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part, but there's a spot where I think we are mutating the Redux store. Other than that, I've just got pointed questions and suggestions.
dashboard/src/modules/components/ProfileComponent/KeyListTable.jsx
Outdated
Show resolved
Hide resolved
dashboard/src/modules/components/ProfileComponent/KeyListTable.jsx
Outdated
Show resolved
Hide resolved
dashboard/src/modules/components/ProfileComponent/NewKeyModal.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great already, although Webb has some good cleanup suggestions I'd like to see added.
dashboard/src/modules/components/ProfileComponent/KeyListTable.jsx
Outdated
Show resolved
Hide resolved
Dashboard API Key Management Develop a UI page where a logged-in user can generate a new key for their account and manage existing keys. GET API keys New API key Modal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
PBENCH-1131
Dashboard API Key Management
Develop a UI page where a logged-in user can generate a new key for their account and manage existing keys.