Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard API Key Management #3423

Merged
merged 5 commits into from
May 18, 2023

Conversation

MVarshini
Copy link
Contributor

PBENCH-1131

Dashboard API Key Management

Develop a UI page where a logged-in user can generate a new key for their account and manage existing keys.

@MVarshini MVarshini added the Dashboard Of and relating to the Dashboard GUI label May 16, 2023
@MVarshini MVarshini added this to the v0.73 milestone May 16, 2023
@MVarshini MVarshini self-assigned this May 16, 2023
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, but there's a spot where I think we are mutating the Redux store. Other than that, I've just got pointed questions and suggestions.

dashboard/src/actions/keyManagementActions.js Outdated Show resolved Hide resolved
dashboard/src/actions/keyManagementActions.js Show resolved Hide resolved
dashboard/src/actions/keyManagementActions.js Outdated Show resolved Hide resolved
dashboard/src/actions/keyManagementActions.js Outdated Show resolved Hide resolved
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great already, although Webb has some good cleanup suggestions I'd like to see added.

dashboard/src/actions/keyManagementActions.js Outdated Show resolved Hide resolved
dashboard/src/actions/keyManagementActions.js Outdated Show resolved Hide resolved
Dashboard API Key Management
Develop a UI page where a logged-in user can generate a new key for their account and manage existing keys.

GET API keys

New API key Modal
Copy link
Member

@siddardh-ra siddardh-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@webbnh webbnh merged commit e26d925 into distributed-system-analysis:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Of and relating to the Dashboard GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants