Don't report API Keys as errors #3438
Conversation
PBENCH-1168 Our API Key structure causes the primary OIDC key validation to fail with a `ValueError` exception. This isn't caught by the handler, and propagates to the caller's `except Exception` where it's reported as an error with traceback, which we don't want for a routine key validation. This just adds `ValueError` to the catch to avoid the annoying log message.
dbutenhof
added
bug
Server
API
|
Destroyed by another dashboard build issue:
(repeated for apparently every one of our Javascript files) I'm going to just sit on this and hope that (once again) it gets fixed without wasting our triage time ... but one never knows ... |
There was a problem hiding this comment.
The code change looks fine.
Regarding the ESLint issue, @babel/core was updated an hour ago....
Of course it was. Does nobody do QA? |
Seems to be fixed now. |
PBENCH-1168
Our API Key structure causes the primary OIDC key validation to fail with a
ValueErrorexception. This isn't caught by the handler, and propagates to the caller'sexcept Exceptionwhere it's reported as an error with traceback, which we don't want for a routine key validation.This just adds
ValueErrorto the catch to avoid the annoying log message.