Dashboard API key copy button #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MVarshini
force-pushed
the
PBENCH-1166
branch
2 times, most recently
from
998118d
to
43dd276
Compare
dbutenhof
previously approved these changes
Jun 5, 2023
dashboard/src/modules/components/ProfileComponent/ClipboardCopy.jsx
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
webbnh
previously approved these changes
Jun 5, 2023
dashboard/src/modules/components/ProfileComponent/ClipboardCopy.jsx
Outdated
Show resolved
Hide resolved
dbutenhof
requested changes
Jun 6, 2023
There was a problem hiding this comment.
I'd like to see a code comment record the logic for the deprecated copy fallback. Maybe even with a TODO explaining that it can be removed once we've upgraded the Pbench Server to handle incoming https connections. (We'll be dropping http entirely at that point, and this should happen "soon".)
webbnh
previously approved these changes
Jun 6, 2023
dashboard/src/modules/components/ProfileComponent/ClipboardCopy.jsx
Outdated
Show resolved
Hide resolved
dbutenhof
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1166
Dashboard API key copy button
The copy icon on the API Key table doesn't appear to have any effect.