Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URI to TOC API #3471

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Add URI to TOC API #3471

merged 3 commits into from
Jun 27, 2023

Commits on Jun 26, 2023

  1. Add URI to TOC API 

    PBENCH-624

We're not quite ready to rebuild the `/datasets/{dataset}/contents` API on the
cache manager. (I actually tried; it's not all there, and currently would need
to be built via a full tarball unpack each time we build a `CacheManager`
instance, while the changes to persist it via SQL or Redis, which I'd like to
do soon, seemed too big a lift right now.)

However, we have planned for some time to supplement the TOC information with
a uri element for each file and subdirectory; this much smaller change makes the
code match the API documentation.
    @dbutenhof
    dbutenhof committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    969d2ec View commit details
    Browse the repository at this point in the history

  2. Rough changes to the Javascript 

    With these changes, it's possible to navigate down the directory hierarchy.
Navigating backwards on the "breadcrumb" line (still) doesn't quite work, but
I now believe that my URI change in the API hasn't made anything worse than it
was before.
    @dbutenhof
    dbutenhof committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    24f6ff8 View commit details
    Browse the repository at this point in the history

  3. Review

    @dbutenhof
    dbutenhof committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    79f0863 View commit details
    Browse the repository at this point in the history