Fix handling of labeled hosts by pbench-postprocess-tools (fwd port of #3456) #3472
Conversation
…rt of distributed-system-analysis#3456) Fixes distributed-system-analysis#3454 pbench-postprocess-tools mishandles hosts with labels (added by tool registration commands): it ignores the label and complains that it cannot find the tool output directory. The tool output directory path contains '<label>:<host>' as one element in the path but pbench-postprocess-tools looks for a '<host>' element. pbench-postprocess-tools parses the output of pbench-list-tools to get the tool info it needs, but pbench-list-tools omits the label from its output. This PR fixes pbench-list-tools to add the label to its output and pbench-postprocess-tools to parse that output, derive the label and use it to construct the path of the tool output directory. It also adds a "functional" test for pbench-list-tools to verify the output when labeled hosts have registered tools and fixes an incorrect legacy test (test-07) for pbench-postprocess-tools: the test was using a labeled host, but it was testing the wrong tool output directory (without the label). It adds a similar legacy test (test-07.1) to test the unlabeled host case. Bump the version to 0.72.1 PBENCH-1178
ndokos
added
bug
Agent
tools
|
The Duration message is printed by the |
There was a problem hiding this comment.
I have sometimes gotten "half-a-bit" failures in some postprocessing scripts when comparing floating-point numbers: is the failure you are seeing of that kind or is it something else?
There weren't any details, so it's hard to say. In any case, it clearly didn't reproduce. Though I don't doubt that we'll see it again sooner or later ...
It is. It's much less flakey than "Area-51" (and -52), but it does occasionally hang and time out. |
Make the version be 1.0.
lib/pbench/test/functional/agent/cli/commands/tools/test_tools_list.py
Outdated
Show resolved
Hide resolved
I neglected to include this change in the previous commit.
Fixes #3454
pbench-postprocess-tools mishandles hosts with labels (added by tool registration commands): it ignores the label and complains that it cannot find the tool output directory. The tool output directory path contains ':' as one element in the path but pbench-postprocess-tools looks for a '' element.
pbench-postprocess-tools parses the output of pbench-list-tools to get the tool info it needs, but pbench-list-tools omits the label from its output.
This PR fixes pbench-list-tools to add the label to its output and pbench-postprocess-tools to parse that output, derive the label and use it to construct the path of the tool output directory.
It also adds a "functional" test for pbench-list-tools to verify the output when labeled hosts have registered tools and fixes an incorrect legacy test (test-07) for pbench-postprocess-tools: the test was using a labeled host, but it was testing the wrong tool output directory (without the label). It adds a similar legacy test (test-07.1) to test the unlabeled host case.
Bump the version to 0.72.1
PBENCH-1178